Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add support for flutter-dashboard and Cirrus CI in the CI Test Check #1547

Closed
godofredoc opened this issue Jan 27, 2022 · 2 comments · Fixed by #1548
Closed

Feature: add support for flutter-dashboard and Cirrus CI in the CI Test Check #1547

godofredoc opened this issue Jan 27, 2022 · 2 comments · Fixed by #1548
Labels
kind/enhancement New feature or request

Comments

@godofredoc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Yes, Dart and Flutter are enabling score card for both Flutter and Dart orgs. As we started addressing the alerts we found that CI Test validation is failing because flutter-dashboard(LUCI) and Cirrus CI are not included in the list of CI systems.

Describe the solution you'd like
I'm planning to send a PR to add "flutter-dashboard" and "Cirrus CI" to the CI systems list.

Describe alternatives you've considered
N/A

Additional context
N/A
@godofredoc godofredoc added the kind/enhancement New feature or request label Jan 27, 2022
godofredoc added a commit to godofredoc/scorecard that referenced this issue Jan 27, 2022
@godofredoc
Add Dart and Flutter CI systems to CI tests check.
5200617 
The current check is looking at the github checks data to identify
whether a given PR ran tests. Flutter and Dart repos are failing the
check becuase their systems are not recognized as CI Systems.

Bug: ossf#1547
@godofredoc godofredoc mentioned this issue Jan 27, 2022
Merged
2 tasks
@laurentsimon
Copy link
Contributor

laurentsimon commented Jan 27, 2022 •
edited
Loading

Brilliant, thanks for filing the issue. I'll take a look at the PR today.

godofredoc added a commit to godofredoc/scorecard that referenced this issue Jan 28, 2022
@godofredoc
Add Dart and Flutter CI systems to CI tests check.
cc13afa 
The current check is looking at the github checks data to identify
whether a given PR ran tests. Flutter and Dart repos are failing the
check becuase their systems are not recognized as CI Systems.

Bug: ossf#1547
naveensrinivasan pushed a commit that referenced this issue Jan 28, 2022
@godofredoc
🌱 Add Dart and Flutter CI systems to CI tests check. (#1548)
a69e1d9 
* Add Dart and Flutter CI systems to CI tests check.

The current check is looking at the github checks data to identify
whether a given PR ran tests. Flutter and Dart repos are failing the
check becuase their systems are not recognized as CI Systems.

Bug: #1547

* Format file.
@azeemshaikh38 azeemshaikh38 linked a pull request Jan 30, 2022 that will close this issue
🌱 Add Dart and Flutter CI systems to CI tests check. #1548
Merged
2 tasks
@azeemshaikh38
Copy link
Contributor

Closing this since #1548 addresses this issue. Feel free to re-open if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Add Dart and Flutter CI systems to CI tests check. godofredoc/scorecard
3 participants
@azeemshaikh38 @godofredoc @laurentsimon