Feature/better project page #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le for use on the project page.
… start handling them and communicating them to the user.
…h cannot be parsed.
|
This is separate from the file tree work. |
|
Found some issues, don't merge. |
|
Fixed... |
… promises for the file contents on the file object.
…ile list. Use a modified version of the file-tree module with a bug fix until the pull request with the fix is accepted.
…file tree. Add a polyfill file.
…irectory. Render that.
|
Okay, re-opening with basic file tree work done. Files are arranged by directory clicking the directory name will toggle those files. |
…ts after reopening it.
|
@sponte Ready for review, although it will probably need us both. We have the data to do whatever we want with the UI but I'd suggest this is good enough for now. |
| @@ -261,7 +262,7 @@ function getAllFiles(tree) { | |||
| return _getAllFiles(tree) | |||
| .then(function (files) { | |||
| return files.filter(function (f) { | |||
| return /\.(feature|md)/.test(f); | |||
| return (appConfig.regex.fileOfInterest).test(f); | |||
There was a problem hiding this comment.
Can we move file filtering into project.js rather at low level inside please?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redesign the project page. See individual commit messages.
Also note a bug in the update functionality, reported in #137 .