Cli module query params

CHANGELOG.md

@@ -52,6 +52,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### State Compatible
 * [#8494](https://github.com/osmosis-labs/osmosis/pull/8494) Add additional events in x/lockup, x/superfluid, x/concentratedliquidity
 
+* [#8504](https://github.com/osmosis-labs/osmosis/pull/8504) Add missing module params query to CLI
+
 ## v25.2.0
 
 * [#8455](https://github.com/osmosis-labs/osmosis/pull/8455) Further comet mempool improvements

cmd/osmosisd/cmd/root.go

@@ -524,7 +524,7 @@ func overwriteConfigTomlValues(serverCtx *server.Context) error {
 		}()
 
 		// Check if the file is writable
-		if fileInfo.Mode()&os.FileMode(0200) != 0 {
+		if fileInfo.Mode()&os.FileMode(0o200) != 0 {
 			// It will be re-read in server.InterceptConfigsPreRunHandler
 			// this may panic for permissions issues. So we catch the panic.
 			// Note that this exits with a non-zero exit code if fails to write the file.
@@ -585,7 +585,7 @@ func overwriteAppTomlValues(serverCtx *server.Context) error {
 		}
 
 		// Check if the file is writable
-		if fileInfo.Mode()&os.FileMode(0200) != 0 {
+		if fileInfo.Mode()&os.FileMode(0o200) != 0 {
 			// It will be re-read in server.InterceptConfigsPreRunHandler
 			// this may panic for permissions issues. So we catch the panic.
 			// Note that this exits with a non-zero exit code if fails to write the file.
@@ -640,7 +640,7 @@ func initAppConfig() (string, interface{}) {
 		WasmConfig wasmtypes.WasmConfig `mapstructure:"wasm"`
 	}
 
-	var DefaultOsmosisMempoolConfig = OsmosisMempoolConfig{
+	DefaultOsmosisMempoolConfig := OsmosisMempoolConfig{
 		MaxGasWantedPerTx:         "60000000",
 		MinGasPriceForArbitrageTx: ".1",
 		MinGasPriceForHighGasTx:   ".0025",
@@ -816,6 +816,7 @@ func initRootCmd(rootCmd *cobra.Command, encodingConfig params.EncodingConfig, t
 		txCommand(tempApp.ModuleBasics),
 		keys.Commands(),
 	)
+	rootCmd.AddCommand(CmdListQueries(rootCmd))
 	// add rosetta
 	rootCmd.AddCommand(rosettaCmd.RosettaCommand(encodingConfig.InterfaceRegistry, encodingConfig.Marshaler))
 }
@@ -826,6 +827,28 @@ func addModuleInitFlags(startCmd *cobra.Command) {
 	startCmd.Flags().Bool(FlagRejectConfigDefaults, false, "Reject some select recommended default values from being automatically set in the config.toml and app.toml")
 }
 
+// CmdListQueries list all available modules' queries
+func CmdListQueries(rootCmd *cobra.Command) *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "list-queries",
+		Short: "listing all available modules' queries",
+		RunE: func(cmd *cobra.Command, args []string) error {
+			for _, cmd := range rootCmd.Commands() {
+				if cmd.Name() != "query" {
+					continue
+				}
+				for _, cmd := range cmd.Commands() {
+					for _, cmd := range cmd.Commands() {
+						fmt.Println(cmd.CommandPath())
+					}
+				}
+			}
+			return nil
+		},
+	}
+	return cmd
+}
+
 func CmdModuleNameToAddress() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "module-name-to-address [module-name]",

proto/osmosis/gamm/v1beta1/genesis.proto

@@ -6,15 +6,7 @@ import "google/protobuf/any.proto";
 import "cosmos_proto/cosmos.proto";
 import "cosmos/base/v1beta1/coin.proto";
 import "osmosis/gamm/v1beta1/shared.proto";
-
-// Params holds parameters for the incentives module
-message Params {
-  repeated cosmos.base.v1beta1.Coin pool_creation_fee = 1 [
-    (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins",
-    (gogoproto.moretags) = "yaml:\"pool_creation_fee\"",
-    (gogoproto.nullable) = false
-  ];
-}
+import "osmosis/gamm/v1beta1/params.proto";
 
 option go_package = "github.com/osmosis-labs/osmosis/v25/x/gamm/types";
 

proto/osmosis/gamm/v1beta1/params.proto

@@ -0,0 +1,17 @@
+syntax = "proto3";
+package osmosis.gamm.v1beta1;
+
+import "gogoproto/gogo.proto";
+import "cosmos_proto/cosmos.proto";
+import "cosmos/base/v1beta1/coin.proto";
+
+option go_package = "github.com/osmosis-labs/osmosis/v25/x/gamm/types";
+
+// Params holds parameters for the incentives module
+message Params {
+  repeated cosmos.base.v1beta1.Coin pool_creation_fee = 1 [
+    (gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins",
+    (gogoproto.moretags) = "yaml:\"pool_creation_fee\"",
+    (gogoproto.nullable) = false
+  ];
+}

proto/osmosis/gamm/v1beta1/query.proto

@@ -11,6 +11,7 @@ import "google/api/annotations.proto";
 import "google/protobuf/any.proto";
 import "cosmos_proto/cosmos.proto";
 import "osmosis/gamm/v1beta1/shared.proto";
+import "osmosis/gamm/v1beta1/params.proto";
 
 option go_package = "github.com/osmosis-labs/osmosis/v25/x/gamm/types";
 
@@ -124,8 +125,17 @@ service Query {
     option (google.api.http).get =
         "/osmosis/gamm/v1beta1/cfmm_concentrated_pool_links";
   }
+
+  // Params returns gamm module params.
+  rpc Params(ParamsRequest) returns (ParamsResponse) {
+    option (google.api.http).get = "/osmosis/gamm/v1beta1/params";
+  }
 }
 
+//=============================== Params
+message ParamsRequest {}
+message ParamsResponse { Params params = 1 [ (gogoproto.nullable) = false ]; }
+
 //=============================== Pool
 // Deprecated: please use the alternative in x/poolmanager
 message QueryPoolRequest {

proto/osmosis/incentives/query.proto

@@ -9,6 +9,7 @@ import "cosmos/base/query/v1beta1/pagination.proto";
 import "osmosis/incentives/gauge.proto";
 import "osmosis/lockup/lock.proto";
 import "osmosis/incentives/group.proto";
+import "osmosis/incentives/params.proto";
 
 option go_package = "github.com/osmosis-labs/osmosis/v25/x/incentives/types";
 
@@ -95,6 +96,10 @@ service Query {
         "/osmosis/incentives/v1beta1/current_weight_by_group_gauge_id/"
         "{group_gauge_id}";
   }
+  // Params returns incentives module params.
+  rpc Params(ParamsRequest) returns (ParamsResponse) {
+    option (google.api.http).get = "/osmosis/incentives/v1beta1/params";
+  }
 }
 
 message ModuleToDistributeCoinsRequest {}
@@ -236,4 +241,7 @@ message GaugeWeight {
     (gogoproto.moretags) = "yaml:\"weight_ratio\"",
     (gogoproto.nullable) = false
   ];
-}
+}
+
+message ParamsRequest {}
+message ParamsResponse { Params params = 1 [ (gogoproto.nullable) = false ]; }

x/gamm/client/cli/query.go

@@ -30,6 +30,10 @@ func GetQueryCmd() *cobra.Command {
 	osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCmdEstimateSwapExactAmountOut)
 	osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetConcentratedPoolIdLinkFromCFMMRequest)
 	osmocli.AddQueryCmd(cmd, types.NewQueryClient, GetCFMMConcentratedPoolLinksRequest)
+	cmd.AddCommand(
+		osmocli.GetParams[*types.ParamsRequest](
+			types.ModuleName, types.NewQueryClient),
+	)
 	cmd.AddCommand(
 		GetCmdNumPools(),
 		GetCmdPoolParams(),

x/gamm/keeper/grpc_query.go

@@ -44,6 +44,17 @@ func NewV2Querier(k Keeper) QuerierV2 {
 	return QuerierV2{Keeper: k}
 }
 
+func (q Querier) Params(ctx context.Context, req *types.ParamsRequest) (*types.ParamsResponse, error) {
+	if req == nil {
+		return nil, status.Error(codes.InvalidArgument, "empty request")
+	}
+	sdkCtx := sdk.UnwrapSDKContext(ctx)
+	params := q.Keeper.GetParams(sdkCtx)
+	return &types.ParamsResponse{
+		Params: params,
+	}, nil
+}
+
 // Pool checks if a pool exists and their respective poolWeights.
 // Deprecated: use x/poolmanager's Pool query.
 // nolint: staticcheck

x/gamm/keeper/grpc_query_test.go

@@ -17,6 +17,17 @@ import (
 	poolmanagertypes "github.com/osmosis-labs/osmosis/v25/x/poolmanager/types"
 )
 
+func (s *KeeperTestSuite) TestParams() {
+	queryClient := s.queryClient
+	ctx := s.Ctx
+
+	expectedParams := s.App.GAMMKeeper.GetParams(s.Ctx)
+
+	params, err := queryClient.Params(ctx, &types.ParamsRequest{})
+	s.Require().NoError(err)
+	s.Require().Equal(expectedParams, params.Params)
+}
+
 func (s *KeeperTestSuite) TestCalcExitPoolCoinsFromShares() {
 	queryClient := s.queryClient
 	ctx := s.Ctx