-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli module query params #8504
Cli module query params #8504
Conversation
@czarcas7ic This is a draft of what I have understand about the issue. If it is mostly about you are expecting I'll continue to add params queries for the other modules. |
I'm on mobile but at glance this looks like what is desired, thanks! |
WalkthroughThe changes introduce a new function Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant gRPC Server
participant Keeper
User->>CLI: Run 'osmosisd q gamm params'
CLI->>gRPC Server: Send ParamsRequest
gRPC Server->>Keeper: Fetch Params
Keeper-->>gRPC Server: Return Params
gRPC Server-->>CLI: Send ParamsResponse
CLI-->>User: Display Params
User->>CLI: Run 'osmosisd q list-queries'
CLI->>gRPC Server: Send ListQueriesRequest
gRPC Server->>Keeper: Fetch available queries
Keeper-->>gRPC Server: Return query list
gRPC Server-->>CLI: Send ListQueriesResponse
CLI-->>User: Display available queries
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (2)
Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@mattverse I see you have closed and reopened the PR. Did I do something wrong? Changelog does not pass -> I let you decide if a new line must be added or not. |
No, we do it to trigger our CI when it gets stuck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! LGTM
@najeal Can you add changelog entry please? 🙏 |
@mattverse I added new entry into |
Thanks @najeal seems like there is a merge conflict to resolve as well, can you go ahead and fix it? |
@mattverse conflict resolution has been done 👍 |
Closes: #8460
What is the purpose of the change
This pull request add missing params query for modules used in
osmosisd q
Testing and Verifying
This change added tests and can be verified as follows:
Documentation and Release Note
Unreleased
section ofCHANGELOG.md
?Where is the change documented?
x/{module}/README.md
)