Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wasmEnabledProposals []wasm.ProposalType from NewOsmosisApp #4868

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented Apr 9, 2023

Closes: #4865

What is the purpose of the change

This pull request removeswasmEnabledProposals []wasm.ProposalType arg from NewOsmosisApp and update related files calling the function

Brief Changelog

  • Remove wasmEnabledProposals []wasm.ProposalType from NewOsmosisApp

Testing and Verifying

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations labels Apr 9, 2023
@tungbq tungbq marked this pull request as ready for review April 9, 2023 05:46
@tungbq tungbq marked this pull request as draft April 9, 2023 05:48
@tungbq tungbq marked this pull request as ready for review April 9, 2023 05:56
@pysel pysel added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Apr 9, 2023
Copy link
Member

@pysel pysel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an API breaking changelog entry

@pysel pysel added V:state/compatible/no_backport State machine compatible PR, depends on prior breaks and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Apr 10, 2023
@tungbq
Copy link
Contributor Author

tungbq commented Apr 10, 2023

Hi @ValarDragon, I've updated the API breaking changelog in latest commit

@p0mvn p0mvn merged commit 5636b3a into osmosis-labs:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:simulator Edits simulator or simulations V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove wasmEnabledProposals []wasm.ProposalType from NewOsmosisApp
4 participants