Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wasmEnabledProposals []wasm.ProposalType from NewOsmosisApp #4865

Closed
ValarDragon opened this issue Apr 8, 2023 · 1 comment · Fixed by #4868
Closed

Remove wasmEnabledProposals []wasm.ProposalType from NewOsmosisApp #4865

ValarDragon opened this issue Apr 8, 2023 · 1 comment · Fixed by #4868
Labels
Good first issue

Comments

@ValarDragon
Copy link
Member

Background

NewOsmosisApp has too many args. Currently there is an arugment for altering the wasm enabled proposals.

This is as far as I can tell useless, and should be removed. App.go should hardcode this list (which is derived from calling the function)

This should just be a simple deletion of the arg, corresponding calls to it.
@tungbq
Copy link
Contributor

tungbq commented Apr 9, 2023

Can I pick up this task?

@tungbq tungbq mentioned this issue Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove wasmEnabledProposals []wasm.ProposalType from NewOsmosisApp tungbq/osmosis
2 participants
@ValarDragon @tungbq