-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move osmoutils into own mod #3788
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaslara
changed the title
Nicolas/move osmoutils into own mod
Move osmoutils into own mod
Dec 19, 2022
github-actions
bot
added
C:app-wiring
Changes to the app folder
C:CLI
C:simulator
Edits simulator or simulations
C:x/epochs
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/incentives
C:x/lockup
C:x/mint
C:x/pool-incentives
C:x/superfluid
C:x/swaprouter
C:x/tokenfactory
C:x/twap
Changes to the twap module
C:x/txfees
T:build
labels
Dec 19, 2022
* Satisfy store_helper code * Make osmoutils tests not integrated
nicolaslara
added
the
V:state/compatible/backport
State machine compatible PR, should be backported
label
Dec 19, 2022
For reference, this is how to get the version string if we want to avoid the replaces:
|
…tils_into_own_mod
Closing for #3827 due to conflicts I made in interrim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:app-wiring
Changes to the app folder
C:CLI
C:simulator
Edits simulator or simulations
C:x/epochs
C:x/gamm
Changes, features and bugs related to the gamm module.
C:x/incentives
C:x/lockup
C:x/mint
C:x/pool-incentives
C:x/superfluid
C:x/swaprouter
C:x/tokenfactory
C:x/twap
Changes to the twap module
C:x/txfees
T:build
V:state/compatible/backport
State machine compatible PR, should be backported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#3771 started moving some of our tools to their own modules. This PR expands that by moving osmoutils.
Both of these are a requirement for #3747
Brief Changelog
(for example:)
github.com/osmosis-labs/osmosis/v13/osmoutils
togithub.com/osmosis-labs/osmosis/osmoutils
Testing and Verifying
All tests still pass
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)