Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move osmoutils into own mod #3788

Closed
wants to merge 36 commits into from

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

#3771 started moving some of our tools to their own modules. This PR expands that by moving osmoutils.

Both of these are a requirement for #3747

Brief Changelog

(for example:)

  • Move osmoutils into its own go.mod. To update, change your osmoutils import from github.com/osmosis-labs/osmosis/v13/osmoutils to github.com/osmosis-labs/osmosis/osmoutils
  • Moved osmoassert to osmoutils
  • Fix Exp2 tests to use assets from osmoutils

Testing and Verifying

All tests still pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@nicolaslara nicolaslara changed the title Nicolas/move osmoutils into own mod Move osmoutils into own mod Dec 19, 2022
@nicolaslara nicolaslara marked this pull request as draft December 19, 2022 14:28
@nicolaslara nicolaslara added the V:state/compatible/backport State machine compatible PR, should be backported label Dec 19, 2022
@nicolaslara nicolaslara marked this pull request as ready for review December 19, 2022 18:28
@nicolaslara
Copy link
Contributor Author

For reference, this is how to get the version string if we want to avoid the replaces:

TZ=UTC git --no-pager show \
  --quiet \
  --abbrev=12 \
  --date='format-local:%Y%m%d%H%M%S' \
  --format="%cd-%h"

@ValarDragon
Copy link
Member

Closing for #3827 due to conflicts I made in interrim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:CLI C:simulator Edits simulator or simulations C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/lockup C:x/mint C:x/pool-incentives C:x/superfluid C:x/swaprouter C:x/tokenfactory C:x/twap Changes to the twap module C:x/txfees T:build V:state/compatible/backport State machine compatible PR, should be backported
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants