Make osmoutils store + module account tests not import osmosis #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
added
V:state/compatible/backport
p0mvn
approved these changes
Dec 17, 2022
|
Woah, I wrote a description for this PR. Must have had some issue with it not getting into github, sorry about that Thank you for the review w/ that issue present! Rewrote the PR desc for future ref: This PR is part of moving osmoutils into its own go.mod. osmoutils depended on the osmosis app for wiring an auth keeper, and a custom store w/ a ctx. This PR makes helpers to make ctxs' more easily with no integrated osmosis app. Its expected to be able to use this in x/epochs and x/downtime-detector as well. unfortunately to wire the auth keeper, we also had to wire params, which took many lines of code. What remains to migrate osmoutils:
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 19, 2022
* Satisfy store_helper code * Make osmoutils tests not integrated (cherry picked from commit 793bb50)
ValarDragon
added a commit
that referenced
this pull request
Dec 19, 2022
#3789) * Satisfy store_helper code * Make osmoutils tests not integrated (cherry picked from commit 793bb50) Co-authored-by: Dev Ojha <[email protected]>
nicolaslara
pushed a commit
that referenced
this pull request
Dec 19, 2022
* Satisfy store_helper code * Make osmoutils tests not integrated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.