Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set MaxAgeNumBlocks in v11 Upgrade Handler #2147

Merged
merged 2 commits into from
Jul 19, 2022
Merged

chore: Set MaxAgeNumBlocks in v11 Upgrade Handler #2147

merged 2 commits into from
Jul 19, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 19, 2022

Closes: #2124

What is the purpose of the change

Ref: #1638

Since the previous upgrade was a fork, the MaxAgeNumBlocks change was not applied during v10 upgrade.

As a result, adding the exact same logic to the v11 handler.

Testing and Verifying

Covered by e2e upgrade tests.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Jul 19, 2022
@p0mvn p0mvn marked this pull request as ready for review July 19, 2022 20:44
@p0mvn p0mvn requested a review from a team July 19, 2022 20:44
ValarDragon
ValarDragon approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make a note in a github issue that during our release testnet testing, we should test this with changing it and staking period to a much smaller number

@p0mvn p0mvn mentioned this pull request Jul 19, 2022
Closed
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 19, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Jul 19, 2022

Lets make a note in a github issue that during our release testnet testing, we should test this with changing it and staking period to a much smaller number

#2153

@mergify mergify bot merged commit edf78ae into main Jul 19, 2022
@mergify mergify bot deleted the roman/max-age-num-blocks-v11 branch July 19, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:automerge C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MaxAgeNumBlocks to v11 Upgrade Handler
2 participants
@p0mvn @ValarDragon