Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set MaxAgeNumBlocks in v10 Upgrade Handler #1638

Merged
merged 10 commits into from
Jun 2, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jun 1, 2022

Set MaxAgeNumBlocks to 186,092 in the v10 upgrade handler.

closes: #1160

@alexanderbez alexanderbez marked this pull request as ready for review June 1, 2022 18:53
@alexanderbez alexanderbez requested a review from a team June 1, 2022 18:53
@alexanderbez
Copy link
Contributor Author

Marking this as blocked as it's now slated for v10

@alexanderbez alexanderbez changed the title chore: Set MaxAgeNumBlocks in v9 Upgrade Handler chore: Set MaxAgeNumBlocks in v10 Upgrade Handler Jun 1, 2022
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM, I'll submit a quick PR for getting the v10 upgrade boilerplate up

mergify bot pushed a commit that referenced this pull request Jun 2, 2022
## What is the purpose of the change

Unblock #1638
@mergify mergify bot merged commit 62c7eb2 into main Jun 2, 2022
@mergify mergify bot deleted the bez/1160-evi-params-upgrade branch June 2, 2022 19:27
mergify bot pushed a commit that referenced this pull request Jul 19, 2022
Closes: #2124

## What is the purpose of the change

Ref: #1638

Since the previous upgrade was a fork, the MaxAgeNumBlocks change was not applied during v10 upgrade.

As a result, adding the exact same logic to the v11 handler.

## Testing and Verifying

Covered by e2e upgrade tests.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update max_age_num_blocks to reflect Osmosis bonding period
2 participants