-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Set MaxAgeNumBlocks in v10 Upgrade Handler #1638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking this as blocked as it's now slated for v10 |
alexanderbez
changed the title
chore: Set MaxAgeNumBlocks in v9 Upgrade Handler
chore: Set MaxAgeNumBlocks in v10 Upgrade Handler
Jun 1, 2022
ValarDragon
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic LGTM, I'll submit a quick PR for getting the v10 upgrade boilerplate up
mergify bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
## What is the purpose of the change Unblock #1638
mergify bot
pushed a commit
that referenced
this pull request
Jul 19, 2022
Closes: #2124 ## What is the purpose of the change Ref: #1638 Since the previous upgrade was a fork, the MaxAgeNumBlocks change was not applied during v10 upgrade. As a result, adding the exact same logic to the v11 handler. ## Testing and Verifying Covered by e2e upgrade tests. ## Documentation and Release Note - Does this pull request introduce a new feature or user-facing behavior changes? no - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no - How is the feature or change documented? not applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
MaxAgeNumBlocks
to 186,092 in the v10 upgrade handler.closes: #1160