Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(e2e): modular test runner #1999

Merged
merged 58 commits into from
Jul 8, 2022
Merged

refactor(e2e): modular test runner #1999

merged 58 commits into from
Jul 8, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 8, 2022 •
edited
Loading

Part of: #1879

What is the purpose of the change

  • Abstractions for chain configuration are introduced
    • baseConfigurer, CurrentBranchConfigurer and UpgradeConfigurer
    • The desired configurer is initialized with the use of a factory design pattern
  • e2e test runner setup is abstracted depending on what the user requests with environment variables
    • Use decorator design pattern to chain the desired setup logic, could be:
      • withIBC
      • withUpgrade
      • withStateSync (in the future)
  • Chain abstraction for executing transactions and querying against the chain directly.

The original work was done here: #1591

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

p0mvn and others added 30 commits May 26, 2022 10:32
@p0mvn
use should_run_go_test to skip e2e
cc47d4f
@p0mvn
attempt to disable upgrade
a4b3b7e
@p0mvn
remporary remove get data from build cache
da06b9d
@p0mvn
go setup
c53f443
@p0mvn
bring back cache
a7b1112
@p0mvn
log for upgrade
e62107e
@p0mvn
invert the disable condition
b07bd5c
@p0mvn
comment
0f56d8d
@p0mvn
add more logic regarding skipping some e2e components
cc7cc82
@p0mvn
fix markdown lint
5e464ce
@p0mvn
change branch to main
fc4955a
@p0mvn
refactor to be able to run local version without building Docker imag…
f4bc3cf 
…e in CI
@p0mvn
remove if on building local image
04f4484
@p0mvn
TestCreatePool runs only post-upgrade
e773bff
@p0mvn
lint
4937b9f
@p0mvn
TestCreatePoolPostUpgrade
9488f2b
@p0mvn
Merge branch 'main' into roman/e2e-skip
c5d5c9f
@p0mvn
Document
afef950
@p0mvn
restore git diff
eaafc27
@p0mvn @ValarDragon
Update tests/e2e/README.md
4816f25 
Co-authored-by: Dev Ojha <[email protected]>
@p0mvn
README updates
3a1ecae
@p0mvn
rename files; move validator configs, factory and constants to separa…
79d57dd 
…te files
@p0mvn
avoid exporting base configurer
26926b6
@p0mvn
all reference to "local" are replaced to" current branch"
4436363
@p0mvn
fix formatting
b94ca5a
@p0mvn
move all docker logic to containers package
af4c528
@p0mvn
move hermes resource to container manager
5205a27
@p0mvn
move val resources to container manager
5c4fcbe
@p0mvn
clear docker resources in manager
9e1a0d2
@p0mvn
unexport hermes resource
f11e5af
@github-actions github-actions bot added C:docs Improvements or additions to documentation T:CI labels Jul 8, 2022
@github-actions github-actions bot removed the T:CI label Jul 8, 2022
@p0mvn p0mvn mentioned this pull request Jul 8, 2022
Closed
@p0mvn p0mvn marked this pull request as ready for review July 8, 2022 00:44
@p0mvn p0mvn requested a review from a team July 8, 2022 00:44
czarcas7ic
czarcas7ic approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! All looks good from my end! 🚀

tests/e2e/README.md Outdated Show resolved Hide resolved
tests/e2e/README.md Outdated Show resolved Hide resolved
tests/e2e/configurer/base.go Outdated Show resolved Hide resolved
tests/e2e/configurer/chain/commands.go Show resolved Hide resolved
tests/e2e/configurer/chain/queries.go Outdated Show resolved Hide resolved
tests/e2e/configurer/chain/queries.go Outdated Show resolved Hide resolved
@ValarDragon ValarDragon merged commit 05375f8 into main Jul 8, 2022
@ValarDragon ValarDragon deleted the roman/e2e-skip branch July 8, 2022 03:55
@p0mvn p0mvn mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
C:docs Improvements or additions to documentation
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @czarcas7ic @ValarDragon