Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): flakiness when upgrading containers for chainB #2039

Closed
p0mvn opened this issue Jul 12, 2022 · 8 comments
Closed

fix(e2e): flakiness when upgrading containers for chainB #2039

p0mvn opened this issue Jul 12, 2022 · 8 comments
Labels
C:e2e T:bug 🐛 Something isn't working T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented Jul 12, 2022

Background

e2e has recently had several refactors. The latest change #1999 has likely caused test flakiness.

Info from @czarcas7ic :

Info from @p0mvn :

Acceptance Criteria

  • investigate and fix e2e test flakiness
  • Re-running CI 10 times does not cause an issue (try making redundant changes to trigger)
@p0mvn
Copy link
Member Author

p0mvn commented Jul 12, 2022

Added more logs here: https://github.com/p0mvn/osmosis/pull/14

Trying to manually trigger e2e in CI multiple times to repro this

@p0mvn
Copy link
Member Author

p0mvn commented Jul 12, 2022

I have 2 updates on this:

  1. I was not able to reproduce in CI with extra logs. Tried running 10 times on my fork: https://github.com/p0mvn/osmosis/runs/7311008352?check_suite_focus=true

  2. The first update should not be a big problem because refactor(e2e): run individual nodes; rely on rpc client in setup #2040 refactors the logic for waiting for a certain height. Instead of using CLI, it now uses Tendermint RPC which should be more reliable and easier to debug. We need this refactor for the next step in state-sync so it might address 2 problems at once.

@p0mvn
Copy link
Member Author

p0mvn commented Jul 15, 2022

@p0mvn p0mvn added this to the E2E: Tech Debt milestone Jul 15, 2022
@czarcas7ic
Copy link
Member

Another recent instance: https://github.com/osmosis-labs/osmosis/runs/7373637913?check_suite_focus=true

This was at initialization though

@czarcas7ic
Copy link
Member

Another instance: https://github.com/osmosis-labs/osmosis/runs/7458951335?check_suite_focus=true

@p0mvn
Copy link
Member Author

p0mvn commented Jul 21, 2022

Had a chat with @nikever about this. The plan is to get something going with the self-hosted runners and retain container logs to improve the debugging experience

@czarcas7ic
Copy link
Member

Awesome, self hosted runners are for sure a game changer

@czarcas7ic
Copy link
Member

Probably fixed by #2556 , am going to close this for now and if we see another instance of this happening we can reopen and look into this deeper

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:e2e T:bug 🐛 Something isn't working T:tests
Projects
Archived in project
Development

No branches or pull requests

2 participants