Test: Additional test cases for TestCalcJoinPoolShares (multi-coin swap) #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
stackman27
changed the title
|
@stackman27 I added some logic for err tolerance in #1731. You might find it useful here |
alexanderbez
changed the base branch from
main
to
bez/TestCalcJoinPoolShares-swap-tests
alexanderbez
reviewed
Jun 9, 2022
There was a problem hiding this comment.
@stackman27 this should be based against bez/TestCalcJoinPoolShares-swap-tests
stackman27
force-pushed
the
sis/TestCalcJoinPoolShares-swap-tests
branch
from
9912c8c to
46a038c
Compare
stackman27
force-pushed
the
sis/TestCalcJoinPoolShares-swap-tests
branch
from
46a038c to
377f525
Compare
| // A_t = amount of deposited asset = 50,000 | ||
| // B_t = existing balance of deposited asset in the pool prior to deposit = 1,000,000,000,000 | ||
| // W_t = normalized weight of deposited asset in pool = 0.5 (equally weighted two-asset pool) | ||
| // swapFeeRatio = (1 - (1 - W_t) * swapFee) |
There was a problem hiding this comment.
Why are we considering swapFeeRatio when depositing with exact ratios (i.e. no swap occurs)?
stackman27
force-pushed
the
sis/TestCalcJoinPoolShares-swap-tests
branch
from
9750c13 to
83c4394
Compare
alexanderbez
deleted the branch
osmosis-labs:bez/TestCalcJoinPoolShares-swap-tests
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: built on top of #1713
What is the purpose of the change
Add additional test cases to TestCalcJoinPoolShares;
Testing and Verifying
This change added tests and can be verified as follows:
Adds unit test that checks shares for multi asset deposits
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)