Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate updates to numShares and newLiquidity in CalcJoinPoolShares #1722

Closed
p0mvn opened this issue Jun 9, 2022 · 3 comments
Closed

Validate updates to numShares and newLiquidity in CalcJoinPoolShares #1722

p0mvn opened this issue Jun 9, 2022 · 3 comments
Assignees
@alexanderbez @mattverse

Comments

@p0mvn
Copy link
Member

p0mvn commented Jun 9, 2022

Unit tests for CalcJoinPoolShares validating that these updates happen should be added in a separate PR

Originally posted by @p0mvn in #1721 (comment)
@p0mvn p0mvn self-assigned this Jun 9, 2022
@daniel-farina daniel-farina moved this to Needs Review 🔍 in Osmosis Chain Development Jun 9, 2022
@p0mvn p0mvn mentioned this issue Jun 9, 2022
Merged
@mattverse mattverse assigned mattverse and unassigned p0mvn Jun 10, 2022
@mattverse
Copy link
Member

mattverse commented Jun 10, 2022 •
edited
Loading

We need

merged to push this forward

@mattverse
Copy link
Member

Currently on getting #1713 getting merged by adding test cases with different ratio

@alexanderbez alexanderbez self-assigned this Jun 10, 2022
@mattverse
Copy link
Member

#1767 closes this

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

@mattverse mattverse

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexanderbez @p0mvn @mattverse