Refactoring to depend on nodeDB interface #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanspersonalgit
force-pushed
the
dev/iavl_data_locality
branch
from
a5ded36 to
47778c8
Compare
p0mvn
reviewed
Feb 21, 2022
| saveFastNodeUnlocked(node *FastNode, shouldAddToCache bool) error | ||
| Has(hash []byte) (bool, error) | ||
| SaveBranch(node *Node) []byte | ||
| resetBatch() error |
There was a problem hiding this comment.
Thanks for the PR. Just a quick note. We should only be adding exported methods to the interface. If there are places where we call unexported methods of nodedb (such as immutable tree, that should be fixed by either:
- finding an exported method to accomplish the task
- exporting the private method
rohanspersonalgit
force-pushed
the
dev/iavl_data_locality
branch
from
47778c8 to
47ee803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a work in progress, just PRing to get some feedback on progress.
Description: This PR changes immutable_tree and mutable_tree to depend on a NodeDB interface instead of concrete implementation. As a result lots of new getter/setters are introduced and other function signatures changed. In addition to this unit tests for mutable_tree have been changed to mock nodeDB rather then relying on the concrete implementation.
Issue: #15