Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAVL Dependency Inversion Refactor - create nodeDB interface for immutable and mutable trees #15

Closed
7 tasks
p0mvn opened this issue Feb 1, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@p0mvn
Copy link
Member

p0mvn commented Feb 1, 2022

Background

Please refer to #14 for more background information.

This task is specific to creating an interface for nodeDB and refactoring mutable and immutable tree to depend on the new abstraction instead of the concrete nodeDB struct.

Acceptance Criteria

  • An interface for nodeDB is created
  • mutable tree is refactored to depend on the new nodeDB interface
  • immutable tree is refactored to depend on the new nodeDB interface
  • mock nodedb is created and existing unit tests are refactored to use the mock
  • existing unit tests are refactore
  • additional unit tests are added where needed
  • all unit tests pass
@p0mvn p0mvn moved this from 🔍 Needs Review to 🕒 Todo in Osmosis Chain Development Feb 1, 2022
@p0mvn p0mvn added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed enhancement New feature or request good first issue Good for newcomers labels Feb 1, 2022
@rohanspersonalgit
Copy link
Collaborator

rohanspersonalgit commented Feb 21, 2022

Hi, looking to contribute! working off my fork here, will appreciate any feedback on my progress as I get my PR ready.
https://github.com/RohansPersonalGit/iavl

@p0mvn
Copy link
Member Author

p0mvn commented Feb 21, 2022

thanks, @rohanspersonalgit . I saw a draft PR and will get back to you there soon

@p0mvn
Copy link
Member Author

p0mvn commented May 10, 2022

Given how risky changes on IAVL are. I think that this refactor is not worth the effort so I'm going to close this. Please let me know if any concerns

@p0mvn p0mvn closed this as completed May 10, 2022
Repository owner moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants