Introduce separation of names from linked places #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the names tracable and ensures that all names are searchable when they differ. Do not keep names when they are exactly the same to save some space. Linked names are cleaned out before relinking.
These have returned a 0 until now.
Convert the '_place_*' entries back to normal entries before returning them in the 'namedetails' section. If the name field is duplicated, kept the '_place_*' notation. This preserves the previous behaviour before _place_ names were introduces but adds the additional names from the linked place for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, when a place node was linked to a admin boundary, the names of both objects simply got merged. This has two major disadvantages:
This PR changes the merge process. Names from the place node will be added with the prefix
_place_added to the key into the name hstore, if (and only if) the names differ in some way. Either the value is another one or the key is completely missing. These artificial names are then removed again before reindexing a boundary relation. The prefixed and non-prefixed names are transparently merged before creating display names or sending them back via the API, so that the behaviour looks the same from an API user point of view. Only when place node and boundary disagree on the value of a name tag, the name on the place node is now also available with the_place_prefix.