Take _place_name* keys into consideration on import #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nominatim has changed its behaviour and does not overwrite names anymore when linking boundaries and place nodes. Names from places are now found in artificial '_place_*' tags. Search both name variants when building names and addresses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In osm-search/Nominatim#2637 Nominatim changed its behaviour how it handles names from linked place nodes. They no longer overwrite the name of a boundary they are linked to. Instead the names are added with the additional prefix
_place_.This PR adapts the import process to also look for these new
_place_*name keys. As before, the name from a place node is preferred.