Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-namespaced Croatian networks #310

Merged
merged 3 commits into from
May 8, 2022
Merged

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented May 7, 2022

Removed shield definitions for network=Autoceste and Državne ceste, which are prevalent in Croatia. Although these network values are apparently written in Croatian, nothing in these values explicitly constrains them to Croatia, making them even more ambiguous than the Japanese urban expressway values under discussion in #219 and akin to the German values under discussion in #149. As far as I can tell, network=Autoceste is undocumented. network=Državne ceste is documented, but the wiki’s handling of spaces in article titles has resulted in some confusion.

Since this project is pioneering the use of network to choose shields, it would be irresponsible for us to “lock in” an atypical, potentially ambiguous value before the community has had a chance to consider less risky approaches. We wouldn’t want the community to be constrained by backwards compatibility concerns just because this project rushed to support the existing tag.

Internally to the project, these definitions also piggyback on unrelated shield definitions from other countries that happen to look similar, resulting in some confusing uses of these country codes. In cases where multiple unrelated networks happen to require similar-looking shields, we should factor out a generically named shield definition that can be reused without this additional confusion.

Rest assured, routes tagged network=Autoceste and network=Državne ceste will continue to be labeled, just with generic white shields instead of Slovene and Czech shields. The removal of these definitions affects neither the world shield coverage map nor the taginfo project file, because both build steps rely on country code prefixes in network values.

/ref #149 #219 (comment)

Copy link
Member

@claysmalley claysmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree with dropping support for these shields until a discussion is had among the Croatian community about tagging guidelines for highways in Croatia.

Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with this change for the reason described in #219 (comment)

@ZeLonewolf ZeLonewolf merged commit 6f2e639 into main May 8, 2022
@ZeLonewolf ZeLonewolf deleted the 1ec5-hr-unprefixed branch May 8, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants