-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nagoya and Shuto urban expressway shields #219
base: main
Are you sure you want to change the base?
Conversation
[ | ||
"首都高速道路", // Shuto | ||
"名古屋高速道路", // Nagoya | ||
].forEach((network) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Japan’s urban expressways are toll roads with route naming and numbering reminiscent of bus and subway lines. There appear to be several tagging schemes. This style can only support the following tagging scheme:
- Routes in the Shuto and Nagoya expressway networks are tagged
network=首都高速道路
andnetwork=名古屋高速道路
, respectively. Though these networks lack a country code prefix, only Japan and Taiwan haveroute
networks suffixed with 高速道路, which means “highway”, and only Japan’s haveref
s.
This style cannot support the following tagging schemes:
- Routes in the Hanshin expressway network lack
network
tags but are taggedoperator=阪神高速道路
and belong to acollection
relation. - Routes in the Hiroshima expressway network lack
network
oroperator
tags but belong to acollection
relation. - Routes in the Fukuoka expressway network lack
network
oroperator
tags but belong toroute_master
relations that are part of acollection
relation.
OpenMapTiles doesn’t expose operator
. It doesn’t know anything about collection
relations, which are frowned upon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The graphics look great. Regarding network=首都高速道路
and network=名古屋高
I'd be concerned about adding support for non-prefixed route networks if we're not supporting them in Europe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We’re currently supporting more ambiguous network
values from Croatia. At least these networks say exactly which metropolitan area they’re located in.
But I agree that these seem to be evidence of a freeform-name approach to network
tagging, analogous to public transportation routes as I mentioned above. (The parallels are striking: in Japan, expressway interchanges are conceptualized almost like subway station stops.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These Croatian shield definitions were removed in #310.
style/js/shield_defs.js
Outdated
[ | ||
"aichi", | ||
"akita", | ||
"aomori", | ||
"chiba", | ||
"ehime", | ||
"fukui", | ||
"fukuoka", | ||
"fukushima", | ||
"gifu", | ||
"gunma", | ||
"hiroshima", | ||
"hokkaido", | ||
"hyogo", | ||
"ibaraki", | ||
"ishikawa", | ||
"iwate", | ||
"kagawa", | ||
"kagoshima", | ||
"kanagawa", | ||
"kochi", | ||
"kumamoto", | ||
"kyoto", | ||
"mie", | ||
"miyagi", | ||
"miyazaki", | ||
"nagano", | ||
"nagasaki", | ||
"nara", | ||
"niigata", | ||
"oita", | ||
"okayama", | ||
"okinawa", | ||
"osaka", | ||
"saga", | ||
"saitama", | ||
"shiga", | ||
"shimane", | ||
"shizuoka", | ||
"tochigi", | ||
"tokushima", | ||
"tokyo", | ||
"tottori", | ||
"toyama", | ||
"wakayama", | ||
"yamagata", | ||
"yamaguchi", | ||
"yamanashi", | ||
].forEach((prefecture) => { | ||
shields[`JP:prefectural:${prefecture}`] = shields["JP:prefectural"]; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two tagging schemes for prefectural highways: network=JP:prefectural
and network=JP:prefectural:*
, qualified by the prefecture name. JP:prefectural
is the more common scheme, but both are on the rise.
As far as I can tell, the situation on the ground is similar to county routes in some U.S. states. The shields are uniform nationwide, except for a legend at the bottom that differs by prefecture. However, each prefecture numbers its highways independently, so numbers frequently get reused across borders.
78cb222
to
deaaf87
Compare
In my opinion, the primary objective should be adequately unambiguous From a practical standpoint, the networks in #149 were problematic because one country or other had reserved a generic word or opaque acronym for itself, raising the prospect of a naming collision between unrelated networks. A value like No such conflict is conceivable with a network value that spells out a fully qualified name of the network in full in the local language. It’s incredibly unlikely that another city will ever have a reason to name their route network “名古屋高速道路”, which literally means “Nagoya Expressway” in Chinese and Japanese and no other language. In effect, the use of CJK has inherently namespaced this value to a handful of countries, and the inclusion of “Nagoya” geocodes the network more precisely than any code-based namespace in use outside of the U.S. That said, I understand the discomfort with consuming a network value that looks so exotic because it isn’t in a Latin alphabet. If the prevailing opinion is that a machine-readable key should only be set to Latin values, then the way forward would be to reach out to the Japanese community about choosing new values that conform to this expectation. In the meantime, splitting out the uncontroversial networks in #307 will help focus this discussion. |
My specific discomfort is in positioning Americana to be the first tool that codifies a particular network scheme, in cases where the network scheme was probably just invented on a whim. If it's shown that a network scheme, though "non-standard" is being consumed elsewhere and has become the norm for historical reasons, I'm okay with saying "yes that's weird but it's an accident of history". But if we're truly the first (as taginfo, and a lack of examples of other users indicate), then I would prefer to wait on those until there's some firm indicator that the tagging scheme in question represents an affirmative position on behalf of the community behind it. |
Added route shields for expressways, some urban expressway networks, national highways, and prefectural highways in Japan.
Urban expressways, national highways, and prefectural highways in Tokyo.
Expressways, urban expressways, and national highways in Nagoya.
The shield blanks are based on public domain urban expressway, national route, and prefectural route sign blanks on Wikimedia Commons.