Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot icon for cities and star icons for capital cities #30

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

zekefarwell
Copy link
Collaborator

Closes #24.

This PR adds the following icons for cities:

  • A circle inscribed five pointed star for national capital cities (admin level 2)
  • A plain five pointed star for state capital cities (admin level 4)
  • A dot for other cities

Screenshot 2021-07-11 004718

I originally tried the circle inscribed star for state capitals and a slightly larger, double concentric circle inscribed red star for national capitals as this was a pattern I saw on a number of different US highway maps. However, these icons need to look good at a very small size and it was hard to fit enough detail into the national capital icon while also not looking blurry on a standard resolution screen. So I simplified them and I think the results look pretty good. Let me know what you think.

@zekefarwell zekefarwell requested a review from ZeLonewolf July 11, 2021 12:49
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great. It's amazing how the star-in-a-circle gives the map such an American feel. I tried playing with the zoom that the capital icons appeared at, and I was unable to make it look any better than you have it.

@ZeLonewolf ZeLonewolf merged commit 5bda34d into main Jul 11, 2021
@ZeLonewolf ZeLonewolf deleted the capital-icons branch July 11, 2021 19:00
@Pengor Pengor added this to the 1.0.0 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons for places
3 participants