Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to the check argument in matroid_from_matrix_columns #4287

Merged
merged 1 commit into from
Nov 12, 2024
Merged

changes to the check argument in matroid_from_matrix_columns #4287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Combinatorics/Matroids/matroids.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,9 @@ function matroid_from_hyperplanes(hyperplanes::Union{AbstractVector{T},AbstractS
end

@doc raw"""
matroid_from_matrix_columns(A::MatrixElem)
matroid_from_matrix_columns(A::MatrixElem; check::Bool=true)

A matroid represented by the column vectors of a matrix `A`.
A matroid represented by the column vectors of a matrix `A`. The value of `check` is currently ignored.

See Section 1.1 of [Oxl11](@cite).

Expand Down Expand Up @@ -310,13 +310,13 @@ function matroid_from_matrix_columns(A::MatrixElem; check::Bool=true)
end
end

return matroid_from_bases(bases, ncols(A); check=check)
return matroid_from_bases(bases, ncols(A); check=false)
end

@doc raw"""
matroid_from_matrix_columns(A::MatrixElem)
matroid_from_matrix_rows(A::MatrixElem, check::Bool=true)

A matroid represented by the row vectors of a matrix.
A matroid represented by the row vectors of a matrix. The value of `check` is currently ignored.

See Section 1.1 of [Oxl11](@cite).

Expand Down
Loading