changes to the check argument in matroid_from_matrix_columns #4287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added documentation for the matroid_from_matrix_columns check flag.
Internally i removed the default behaviour of the function to check the selected set of bases if they satisfy the bases axioms. Now it simply never checks the arguments, as I believe they are fulfilled by construction.
The current implementation makes this function unusable for larger matrices. Especially since the check flag isn't documented.
@benlorenz suggested keeping the check argument for consistency, even though it's not used.
This was an issue raised by @dcorey2814.