Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to the check argument in matroid_from_matrix_columns #4287

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Sequenzer
Copy link
Collaborator

@Sequenzer Sequenzer commented Nov 7, 2024

I added documentation for the matroid_from_matrix_columns check flag.

Internally i removed the default behaviour of the function to check the selected set of bases if they satisfy the bases axioms. Now it simply never checks the arguments, as I believe they are fulfilled by construction.

The current implementation makes this function unusable for larger matrices. Especially since the check flag isn't documented.

@benlorenz suggested keeping the check argument for consistency, even though it's not used.

This was an issue raised by @dcorey2814.

@Sequenzer Sequenzer changed the title changed the value of the check flag in matroid_from_matrix_columns changes to the check argument in matroid_from_matrix_columns Nov 7, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (24711ee) to head (2ac3297).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4287   +/-   ##
=======================================
  Coverage   84.49%   84.50%           
=======================================
  Files         641      641           
  Lines       85476    85488   +12     
=======================================
+ Hits        72226    72238   +12     
  Misses      13250    13250           
Files with missing lines Coverage Δ
src/Combinatorics/Matroids/matroids.jl 98.80% <100.00%> (ø)

... and 1 file with indirect coverage changes

@benlorenz benlorenz merged commit b3ab222 into oscar-system:master Nov 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants