versioninfo: refactor and use the same code for serialization #2994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the versioninfo internals to return a dict with branchname, (full) commit, and date. This is now used for the serialization version as well.
A few small fixes/improvements including:
is_dev
detection since the dependency keys have typeUUID
.git
is not a folderI changed the
oscar_serialization_version
to a ref that is assigned on first use viaget_oscar_serialization_version()
, this way we don't need to run extra subprocesses during precompilation.There should be plenty of fail-safes in there to make sure it doesn't break anything.
fixes #2991