Failed to precompile using Julia 1.10-rc1

[PhyX-Meow]

Julia version: v1.10-rc1
Oscar version: master

In [3]: using Oscar
Precompiling Oscar
        Info Given Oscar was explicitly requested, output will be shown live
fatal: not a git repository (or any of the parent directories)：.git
ERROR: LoadError: failed process: Process(`git -C /home/wuli/.julia/packages/Oscar/Bv8CE log -n 1 --pretty=format:%H`, ProcessExited(128)) [128]

Stacktrace:
  [1] pipeline_error
    @ Base ./process.jl:565 [inlined]
  [2] read(cmd::Cmd)
    @ Base ./process.jl:449
  [3] read
    @ Base ./process.jl:458 [inlined]
  [4] readchomp
    @ Base ./io.jl:974 [inlined]
  [5] serialization_version_info()
    @ Oscar ~/.julia/packages/Oscar/Bv8CE/src/Serialization/main.jl:169
  [6] top-level scope
    @ ~/.julia/packages/Oscar/Bv8CE/src/Serialization/main.jl:181
  [7] include(mod::Module, _path::String)
    @ Base ./Base.jl:489
  [8] include(x::String)
    @ Oscar ~/.julia/packages/Oscar/Bv8CE/src/Oscar.jl:20
  [9] top-level scope
    @ ~/.julia/packages/Oscar/Bv8CE/src/Oscar.jl:249
 [10] include
    @ Base ./Base.jl:489 [inlined]
 [11] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::Nothing)
    @ Base ./loading.jl:2216
 [12] top-level scope
    @ stdin:3
in expression starting at /home/wuli/.julia/packages/Oscar/Bv8CE/src/Serialization/main.jl:181
in expression starting at /home/wuli/.julia/packages/Oscar/Bv8CE/src/Oscar.jl:1
in expression starting at stdin:3
  ✗ Oscar
  0 dependencies successfully precompiled in 34 seconds. 196 already precompiled.

Seem git gives an error, but I cannot understand why precompiling involve git.

[PhyX-Meow]

OK, the problem is

Oscar.jl/src/Serialization/main.jl

Line 169 in 0f7269b

commit_hash = readchomp(`git -C $path log -n 1 --pretty=format:"%H"`)

It runs git in package path where julia installed, which is not a git repo.

[thofma]

@antonydellavecchia one more reason to maybe refactor https://github.com/oscar-system/Oscar.jl/blob/master/src/utils/versioninfo.jl#L20 and use it in the serialization.

[benlorenz]

I will do a refactor of the versioninfo to allow returning just the commit.