fix: link header in keyset pagination #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-jonas
approved these changes
Oct 10, 2023
zepatrik
approved these changes
Oct 10, 2023
| @@ -104,7 +105,7 @@ func Parse(q url.Values, p PageTokenConstructor) ([]Option, error) { | |||
| } | |||
| opts = append(opts, WithToken(parsed)) | |||
| } | |||
| if q.Has("page_size") { | |||
| if q.Get("page_size") != "" { | |||
There was a problem hiding this comment.
I've encountered GET /admin/identities?page_size= a bunch of times while working on this. I can also see an SDK generating code like that, and we should be prepared for that. Previously, this would return 400 with an internal error message referencing strconv.Atoi. Now it's just equal to default.
zepatrik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes some issues in keyset pagination