-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use keyset pagination list identities #3565
Conversation
c689d3c
to
fe52c87
Compare
Codecov Report
@@ Coverage Diff @@
## master #3565 +/- ##
==========================================
+ Coverage 78.10% 78.12% +0.01%
==========================================
Files 341 341
Lines 22820 22882 +62
==========================================
+ Hits 17824 17876 +52
- Misses 3654 3661 +7
- Partials 1342 1345 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things regarding tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just some minor details apart from what the others already pointed out 👍
7931e33
to
225a3c0
Compare
225a3c0
to
f265aad
Compare
https://github.com/ory-corp/cloud/issues/5412
I'd consider this a MVP/stop-gap solution to the immediate problem. The code in ListIdentities needs an overhaul. Since removal of the query builder in #3526, the code is constructed via printf and hard to read 😞.
Also, the assortment of pagination packages in ory/x are wholly confusing 😢
Needs ory/x#729