Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow negative integers as duration in config #389

Closed
wants to merge 1 commit into from

Conversation

littldr
Copy link
Contributor

@littldr littldr commented Sep 1, 2021

solves ory/hydra#2651

A temporary workaround until knadh/koanf#104 is merged. It allows us to use -1 as a valid value for a duration in the configuration of ory/hydra.

Related issue(s)

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@littldr
Copy link
Contributor Author

littldr commented Sep 1, 2021

this PR is superseded by #390

@littldr littldr closed this Sep 1, 2021
@littldr littldr deleted the littldr_fix_integer_durations branch September 1, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant