Allow negative integers as durations #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
the
Duration
getter currently allows the passed value to be an positive integer or a parsable duration string.So that if I pass an integer like
1
I get the same results as if I would pass1ns
.But Golang allows us to have negative duration, e.g.
time.ParseDuration("-1ns")
.Passing the duration string
-1ns
works withkonaf
as expected, but if I pass-1
it will return me a duration with the length of zero.We stumbled about this unexpected behavior in this issue: ory/hydra#2651 (comment)
For consistency reasons I would propose to allow negative integers and treat them in the same way as positive ones.
What do you think?