-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding jaeger tracing schema, updating documentation #830
Conversation
docs/docs/reference/configuration.md
Outdated
If file `$HOME/.oathkeeper.yaml` exists, it will be used as a configuration file | ||
which supports all configuration settings listed below. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this was removed from running npm run gen:config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible, we probably did not run it yet since the script was updated at some point.
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=======================================
Coverage 62.47% 62.47%
=======================================
Files 102 102
Lines 4813 4813
=======================================
Hits 3007 3007
Misses 1531 1531
Partials 275 275 Continue to review full report at Codecov.
|
Looks like this has some conflicts with #832 being merged - could you please take a look? :) |
|
Everything is merged :) |
93083dd
to
79d6a0f
Compare
Rebased! Some cleanup on indentation from #829 |
This PR updates the configuration schema to document the
tracing
block, currently with only support for Jaeger as per #376.This PR addresses two pieces:
tracing
in the configuration file. Although feat: Enable tracing #376 added this functionality, it was only possible to configure via environment variables and not a configuration file, due to being missing in the schema.Related issue(s)
N/A
Checklist
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
This enables users to configure Jaeger tracing via their YAML config. However in future Oathkeeper should also support other kinda of tracing providers from
github.com/ory/x/tracing
for more completeness across all projects.Note:
The tracing schema used does not reference
github.com/ory/x/tracing/config.schema.json
as Oathkeeper does not implement the full functionality. It is however copy and pasted from there with all non-Jaeger implementations removed.