Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding s3/gs/azblob access_rules repositories to configuration reference #829

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

tobbbles
Copy link
Contributor

@tobbbles tobbbles commented Sep 22, 2021

The ability to obtain access_rule files from s3, gs, and azblob was already added and documentation added to the docs/docs/api-access-rules.md page, however it's missing from the configuration reference. This PR adds that documentation to the config schema and updates the configuration reference documentation.

Related issue(s)

#562

Checklist

Further Comments

@tobbbles tobbbles requested a review from aeneasr as a code owner September 22, 2021 09:24
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #829 (4c5301f) into master (7504e1e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #829   +/-   ##
=======================================
  Coverage   62.39%   62.39%           
=======================================
  Files         102      102           
  Lines        4789     4789           
=======================================
  Hits         2988     2988           
  Misses       1528     1528           
  Partials      273      273           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7504e1e...4c5301f. Read the comment docs.

@aeneasr aeneasr merged commit e2433f6 into ory:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants