Roles and policies filter

[sum2000]

Related issue

#121 #20

Proposed changes

Added support for filtering roles and policies as discussed with @aeneasr.

Checklist

• I have read the contributing guidelines
• I have read the security policy
• I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
  vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation within the code base (if appropriate)
• I have documented my changes in the developer guide (if appropriate)

Further comments

I messed up history rewrite in my original PR, resubmitting this one

[CLAassistant]

All committers have signed the CLA.

[aeneasr]

Let me know when this is good for 👁 :)

[sum2000]

Swamped at work, will probably finish this tomorrow.

[sum2000]

Good to review apart from the comments I mentioned

[sum2000]

@aeneasr

[aeneasr]

Sorry I completely dropped the ball on this one! Reviewing now

[aeneasr]

This looks super solid! Only a few minor things left, and also, could you please add a test in the handler? :)

https://github.com/ory/keto/blob/master/engine/ladon/handler_test.go

[aeneasr]

I'm not sure what the problem is - maybe I misunderstood it - but it seems that the member parameter is propagated properly in the SDK? Maybe you could lay out the problem again in one comment, I think I must have missed something.

[sum2000]

@aeneasr ready for review again. A note on the filter method, if someone passing regex query in the filter params then they are treated as exact. This can be changed in future PR. Let's try to close this soon.

[aeneasr]

Awesome - thank you for your patience and hard work, you rock! :)

[sum2000]

@aeneasr My pleasure, many more PRs to come! :)