Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple filter param values in roles and policies list API #134

Closed
sum2000 opened this issue Aug 21, 2019 · 2 comments
Closed

Allow multiple filter param values in roles and policies list API #134

sum2000 opened this issue Aug 21, 2019 · 2 comments
Labels
feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Milestone

Comments

@sum2000
Copy link
Contributor

sum2000 commented Aug 21, 2019

This is a continuation of #124. Currently, only one value can per filter param is supported in the list API. For example, current filter only allows queries like /policies/member=foo&subject=bar, but often times a user needs multiple value search like policies/member=foo&member=baz&subject=bar

This is easy to implement in the storage filter, but the question is what does it mean to pass multiple values? Does it mean AND or OR? I doubt it is possible to support both with the same url format. This REST spec does not provide any guideline for this. This page(https://stackoverflow.com/questions/1746507/authoritative-position-of-duplicate-http-get-query-keys) seems to suggest that the intended behavior is AND.

What are your thoughts?

@wraix
Copy link

wraix commented Dec 12, 2019

You can make arrays in urls with [] then the AND part would be clear as the array would contain the members. But the queries are hard to read.

@aeneasr aeneasr added this to the unplanned milestone Aug 22, 2020
@aeneasr aeneasr added feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one. labels Aug 22, 2020
@aeneasr
Copy link
Member

aeneasr commented Feb 9, 2021

I am closing this issue as our Google Zanzibar-based refactoring is scheduled to be released soon. Ory Keto up to version 0.5 will go in hibernation mode and receive only critical security patches.

@aeneasr aeneasr closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. good first issue A good issue to tackle when being a novice to the project. help wanted We are looking for help on this one.
Projects
None yet
Development

No branches or pull requests

3 participants