Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetOryAccessControlPolicyRoles by member id as well #121

Closed
sum2000 opened this issue Jul 13, 2019 · 7 comments
Closed

GetOryAccessControlPolicyRoles by member id as well #121

sum2000 opened this issue Jul 13, 2019 · 7 comments
Labels
feat New feature or request.

Comments

@sum2000
Copy link
Contributor

sum2000 commented Jul 13, 2019

Is your feature request related to a problem? Please describe.

More and more of our clients are asking for getting roles for a specific member or a group.

Describe the solution you'd like

Have an API GetOryAccessControlPolicyRoles(flavor, Member ID/GroupID) to get all the roles associated with a certain member

Describe alternatives you've considered

Our current workaround involves getting all the roles using ListOryAccessControlPolicyRoles and filter through specific subjects/members. This is not a secure way and also a memory intensive operation. Another potential way I thought was to read the rego_data directly which basically means having another keto API to support this.

Additional context

I have already started working on this so if you would like I can submit a PR for this. I am pretty much only waiting to see if you already have something in the pipeline or have any strong objection against having this API.

@aeneasr
Copy link
Member

aeneasr commented Jul 13, 2019

Yup that makes sense, would you be up for a PR?

@aeneasr aeneasr added the feat New feature or request. label Jul 13, 2019
@sum2000
Copy link
Contributor Author

sum2000 commented Jul 13, 2019

Yes, I will try to get it in! Thanks

@dmonark
Copy link

dmonark commented Apr 7, 2020

Hey @sum2000 any update on this issue?

@sum2000
Copy link
Contributor Author

sum2000 commented Apr 7, 2020

It's already merged

@dmonark
Copy link

dmonark commented Apr 8, 2020

If I understand correctly using this API we can get all policies by subject?, because there is no mentions in doc about this feature.

@malikvikrant
Copy link

Hey @sum2000 do you know how I can access this feature to get the roles based on member ID. I don't see anything related to this in document.

@aeneasr
Copy link
Member

aeneasr commented Aug 21, 2020

Yes, this was resolved! If you have another thing missing or an SDK error please open a new issue for that and fill out the issue template :)

@aeneasr aeneasr closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants