-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for hydra client metadata property #38
adding support for hydra client metadata property #38
Conversation
amihalj
commented
Dec 5, 2019
- added Metadata map[string]interface{} into OAuth2ClientSpec
- added explicit test on POST route to check for metadata and omitted metadata
ok, I'm stuck, don't know what is causing it to fail. Anyone? |
Looks like the generator does not like Googling the error messages, I found the following resources:
Ands sorry for the slow response, I had tons of travel and meeting this week! |
ok, it seems that deep copy does not like if you declare Metadata as new type json.RawMessage. @aeneasr thank you, now it has passed all checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos I believe
@@ -27,4 +27,7 @@ spec: | |||
endpoint: /clients | |||
forwardedProto: https | |||
tokenEndpointAuthMethod: client_secret_basic | |||
metadata: | |||
property1: 1 | |||
propetry2: "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
@@ -37,3 +37,6 @@ spec: | |||
endpoint: /clients | |||
forwardedProto: https | |||
tokenEndpointAuthMethod: client_secret_basic | |||
metadata: | |||
property1: 1 | |||
propetry2: "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it is irrelevant, since any name can be property, but I will correct it.
thanks
The hydra.ory.sh/v1alpha2 was never released. Let's keep the sample at the proper apiVersion
Sorry, I forgot to review this - could you please rebase on master and re-generate the fields? :) |
…ihalj/hydra-maester into feat/adding_metadata_property_support
ORY Continuous Integration seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
rebased on latest master |
Thank you! |