Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all missing oauth client properties to the CRD spec #36

Closed
p-bakker opened this issue Nov 21, 2019 · 6 comments
Closed

Add all missing oauth client properties to the CRD spec #36

p-bakker opened this issue Nov 21, 2019 · 6 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@p-bakker
Copy link

As discussed in #26 there are a whole bunch of oauth client properties missing from the CRD spec.

See https://www.ory.sh/docs/hydra/sdk/api#schemaoauth2client for everything that can be set on an oauth client, at least in Hydra.

In order to make maester a production-ready solution for syncing oauth client registrations between Hydra instances, it should support all properties that an oauth client can have in Hydra

@aeneasr aeneasr added the feat New feature or request. label Nov 21, 2019
@amihalj
Copy link
Contributor

amihalj commented Dec 4, 2019

this is quite a chunk of work, I believe any PR would be welcomed here.
since I am using metadata from the latest hydra release, I could make a PR for that some time soon.

I suggest that hydra community should give a hand here. if there is a list of priorities or critical client properties it would be better that @aeneasr places them here and anyone ready to contribute can jump in

@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2019

Absolutely, unfortunately I have zero experience with CRD Controllers in Kubernetes. The maester efforts are purely community driven at the moment, but as you've might seen we're hiring talented engineers to help out with these projects! For myself to get involved I would probably have to clone myself :D

I will however discuss this with the people who contributed the most to these controllers, maybe we can find an interim solution!

@amihalj
Copy link
Contributor

amihalj commented Dec 6, 2019

@aeneasr I have tried to make a PR #38 for metadata, but CI build is failing. I have tried to dig out the reason but I got stuck. If you know what could be the reason or know who could know I would appreciate it a lot.

thanks

@aeneasr
Copy link
Member

aeneasr commented Dec 6, 2019

Of course, it was on my task list already and I just replied :)

@p-bakker
Copy link
Author

p-bakker commented Dec 6, 2019

Hi,

I/we will contribute, but it'll be a few weeks before we get to it, probably early in the new year

Paul

@github-actions
Copy link

I am marking this issue as stale as it has not received any engagement from the community or maintainers in over half a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas how you could contribute towards resolving it;
  • open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you for your understanding and to anyone who participated in the issue! 🙏✌️

If you feel strongly about this issues and have ideas on resolving it, please comment. Otherwise it will be closed in 30 days!

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

3 participants