Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the script to build adios with Kokkos for Frontier #4303

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Update the script to build adios with Kokkos for Frontier #4303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb0863
Update the script to build adios with kokkos for Frontier
anagainaru Aug 14, 2024
8fa6796
Adding craype-accel-amd-gfx90a back to the build script so the rocm d…
anagainaru Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...ld_scripts/build-adios2-kokkos-crusher.sh → ...d_scripts/build-adios2-kokkos-frontier.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
#!/bin/bash
# shellcheck disable=SC2191

module load rocm/5.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

craype-accel-amd-gfx90a is needed for the rocm devices to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it back and see if this is the issue.
It's strange though because I was able to run with HIP on Frontier with just PrgEnv-gnu-amd/8.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not the issue and it doesn't seem we need craype-accel-amd-gfx90a
I will look again tonight but I will remove it if all our tests work without it.

module load gcc/11.2.0
module load cmake/3.23.2
module load PrgEnv-gnu-amd/8.5.0
module load craype-accel-amd-gfx90a
module load cmake/3.23.2

######## User Configurations ########
Kokkos_HOME=$HOME/kokkos/kokkos
Expand Down