Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the script to build adios with Kokkos for Frontier #4303

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Update the script to build adios with Kokkos for Frontier #4303

merged 2 commits into from
Aug 15, 2024

Conversation

anagainaru
Copy link
Contributor

The gcc and cray modules on Frontier used in the build scripts have been deprecated as of July 2024:

gcc/11.2.0:
   As of July 16, 2024, the 'gcc' module name is deprecated and has been replaced by 'gcc-native'. Running 'module load gcc' from a
   default login shell has undefined behavior due to this name change. Please use 'module load PrgEnv-gnu gcc', or optionally 'module
   load PrgEnv-gnu cpe/23.09' to load older versions of the GNU toolchain. See
   https://docs.olcf.ornl.gov/software/software-news.html#frontier-system-software-update-july-16-2024 for more information.

eisenhauer
eisenhauer previously approved these changes Aug 14, 2024
View reviewed changes
@anagainaru
Copy link
Contributor Author

@eisenhauer Any ideas why the mac-os CIs fail?

@eisenhauer
Copy link
Member

@eisenhauer Any ideas why the mac-os CIs fail?

It looks like maybe the Mac images have changed and gfortran-11 isn't there anymore:

CMake Error at /usr/local/Cellar/cmake/3.30.2/share/cmake/Modules/CMakeDetermineFortranCompiler.cmake:33 (message):
Could not find compiler set in environment variable FC:
gfortran-11.

@vicentebolea ?

@anagainaru
Copy link
Contributor Author

Yeah, it doesn't seem related to the changes here, so maybe you could bypass the requirements and merge this. We can open an issue with this for @vicentebolea

vicentebolea
vicentebolea reviewed Aug 14, 2024
View reviewed changes
scripts/build_scripts/build-adios2-kokkos-frontier.sh
@@ -1,10 +1,8 @@
#!/bin/bash
# shellcheck disable=SC2191

module load rocm/5.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

craype-accel-amd-gfx90a is needed for the rocm devices to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add it back and see if this is the issue.
It's strange though because I was able to run with HIP on Frontier with just PrgEnv-gnu-amd/8.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not the issue and it doesn't seem we need craype-accel-amd-gfx90a
I will look again tonight but I will remove it if all our tests work without it.

eisenhauer
eisenhauer approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is settled and working, then it looks good.

@anagainaru
Copy link
Contributor Author

anagainaru commented Aug 15, 2024 •
edited
Loading

If this is settled and working, then it looks good.

Yes this is ready. Vicente is right , we need craype-accel-amd-gfx90a if we want to use the cray-compiler as our HIP compiler so I left it. I am very confused by the CI, but I think you can bypass it, or I can try to retrigger it.

@vicentebolea vicentebolea merged commit c837711 into ornladios:master Aug 15, 2024
37 of 38 checks passed
@anagainaru anagainaru deleted the build-frontier branch August 15, 2024 16:47
@anagainaru anagainaru added this to the v2.10.2 milestone Oct 1, 2024
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
34e5cf2 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
@vicentebolea vicentebolea mentioned this pull request Oct 23, 2024
Merged
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
ebf4849 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
e4b4207 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 23, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
2d78b6b 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 24, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
fdd6d41 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 24, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
a1a0a3e 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request Oct 24, 2024
@vicentebolea
Merge pull request ornladios#4303 from anagainaru/build-frontier
52d0f65 
Update the script to build adios with Kokkos for Frontier

(cherry picked from commit c837711)
@vicentebolea vicentebolea mentioned this pull request Oct 26, 2024
Merged
vicentebolea added a commit that referenced this pull request Oct 26, 2024
@vicentebolea
Merge branch 'release_210'
450962f 
* release_210: (33 commits)
  Bump version to v2.10.2
  Merge pull request #4379 from vicentebolea/increace-cmake-version-dep-blosc
  Fix missing int64_t definition (#4365)
  Merge pull request #4346 from anagainaru/memSelLayout
  Merge pull request #4343 from anagainaru/gpuSpan
  Compress the lossless part of MGARD data with Zstd. It was uncompressed until now. (#4339)
  Fix an issue when reading blocks in streaming mode, when some producers did not write any block to output. (#4332)
  Fix in python API:  (#4331)
  Merge pull request #4303 from anagainaru/build-frontier
  Merge pull request #4293 from anagainaru/check_parser_lexer
  Derived variables of type StoreData should not record the expression string (#4247)
  Update ReadMe.md (#4243)
  Switch from ROCM_VERSION_MAJOR to HIP_VERSION_MAJOR (#4222)
  Merge pull request #4207 from anagainaru/hide-symbols
  Patch for when both xrootd and derived variables are activated (#4200)
  Add defines for BP3, BP4 and BP5 (#4191)
  Overload NdCopy instead of adding a new argument for the 2.10 release
  Revert "Backport #3759 to Release 2.10 branch. (cherry-picked from master branch #4340) (#4341)"
  Revert "Merge pull request #4189 from pnorbert/campaign-s3-support"
  ci,python: enable python win2022 serial build
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentebolea vicentebolea vicentebolea left review comments

@eisenhauer eisenhauer eisenhauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@anagainaru @eisenhauer @vicentebolea