Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(flake): speed up rebuild by using naersk #76

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

ch4og
Copy link
Contributor

@ch4og ch4og commented Oct 9, 2024

Description of change

Build using naersk which is much faster on rebuilds

How has this been tested? (if applicable)

When building using #75 time decreases from 3m2s to 1m40s
(https://github.com/ch4og/binsider/actions/runs/11246715759/job/31268990666)

@ch4og ch4og requested a review from orhun as a code owner October 9, 2024 02:00
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.33%. Comparing base (c11c887) to head (16567a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #76   +/-   ##
=====================================
  Coverage   3.33%   3.33%           
=====================================
  Files         19      19           
  Lines       2407    2407           
=====================================
  Hits          80      80           
  Misses      2327    2327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ch4og ch4og changed the title feat(flake): speed up rebuild by using naersk perf(flake): speed up rebuild by using naersk Oct 9, 2024
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit ffb35ea into orhun:main Oct 9, 2024
27 of 28 checks passed
@ch4og ch4og deleted the test branch October 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants