Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add nix flake build #75

Merged
merged 2 commits into from
Oct 9, 2024
Merged

chore(ci): add nix flake build #75

merged 2 commits into from
Oct 9, 2024

Conversation

ch4og
Copy link
Contributor

@ch4og ch4og commented Oct 8, 2024

Description of change

Adds flake building to CI

Help is needed to add rust-cache support

@ch4og
Copy link
Contributor Author

ch4og commented Oct 8, 2024

AFAIK pkgs.rustPlatform.buildRustPackage can't use rust-cache so I have no idea what can be done

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.33%. Comparing base (4bc6b7a) to head (b998cde).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #75   +/-   ##
=====================================
  Coverage   3.33%   3.33%           
=====================================
  Files         19      19           
  Lines       2407    2407           
=====================================
  Hits          80      80           
  Misses      2327    2327           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Oct 8, 2024

Maybe @jla2000 or @Titaniumtown has an idea about this

@jla2000
Copy link
Contributor

jla2000 commented Oct 8, 2024

@ch4og I think you will need to cache the nix store.

@Titaniumtown
Copy link

Maybe @jla2000 or @Titaniumtown has an idea about this

I'm not too familiar with using nix with github actions, srry :(

@ch4og
Copy link
Contributor Author

ch4og commented Oct 8, 2024

@ch4og I think you will need to cache the nix store.

Doesn't nix magic cache do this?

@ch4og
Copy link
Contributor Author

ch4og commented Oct 9, 2024

Should be good to merge

Caching nix store using other way worked. It uses cache after first build now

But this build time can be decreased even more with #76

@ch4og ch4og marked this pull request as ready for review October 9, 2024 02:01
@ch4og ch4og requested a review from orhun as a code owner October 9, 2024 02:01
flake.nix Outdated Show resolved Hide resolved
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks guys!

@orhun orhun merged commit c11c887 into orhun:main Oct 9, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants