feat: support tagging multiple tags at once to a remote registry #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 72.54% 72.54%
=======================================
Files 14 14
Lines 510 510
=======================================
Hits 370 370
Misses 112 112
Partials 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wwwsylvia
reviewed
Sep 16, 2022
cmd/oras/tag/tag.go
Outdated
| // Override PushReference method to print off which tag(s) were added successfully. | ||
| func (w *wrapper) PushReference(ctx context.Context, expected ocispec.Descriptor, content io.Reader, reference string) error { | ||
| if err := w.Repository.PushReference(ctx, expected, content, reference); err != nil { | ||
| return fmt.Errorf("failed %s", reference) |
There was a problem hiding this comment.
The failed %s error message looks a bit confusing. What does the error message look like if we return the err directly?
There was a problem hiding this comment.
the error itself looks like: Error: failed to tag localhost:12900/hello:latest as tag55:1,: invalid reference: invalid tag
changed to what Shiwei suggested fmt.Errorf("%s: %w", reference, err) and now error looks like: Error: failed to tag localhost:12900/hello:latest as tag55:1,: tag55:1,: invalid reference: invalid tag
shizhMSFT
requested changes
Sep 16, 2022
Signed-off-by: Jun <[email protected]>
shizhMSFT
requested changes
Sep 19, 2022
shizhMSFT
reviewed
Sep 19, 2022
added 2 commits
September 19, 2022 19:40
Signed-off-by: Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #355
Signed-off-by: Jun [email protected]