Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tags at the once #355

Closed
mbaykara opened this issue Feb 24, 2022 · 11 comments · Fixed by #574 or #617
Closed

Multiple tags at the once #355

mbaykara opened this issue Feb 24, 2022 · 11 comments · Fixed by #574 or #617
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mbaykara
Copy link

mbaykara commented Feb 24, 2022

I did not find either in the documentation of oras or somewhere else. Is there any multi-tagging support?
i.e:

oras push myregistry/artifact:a,b,c then in my registry following artifacs are available:

myregistry/artifact:a
myregistry/artifact:b
myregistry/artifact:c

I know I can make for each tag a oras push but the feature might be already there.

@shizhMSFT
Copy link
Contributor

Instead of pushing mutiple tags at once, it makes more sense if we have something like oras tag. /cc @qweeah

@mbaykara
Copy link
Author

mbaykara commented Mar 4, 2022

I mean, the way of how other tools like ko, jib works is more convinced to me. It does not require an extra command to append it.

myregistry/artifact:tag1,tag2,tag3

Currently, I don't see how the oras tag makes more sense. Could you explain more? @shizhMSFT

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Mar 4, 2022

If it is just for oras push scenario, it seems a better UX. Since a comma , is not a valid symbol in a tag name [\w][\w.-]{0,127}, we can add it as a seperator for oras push the next iteration of oras development.

@shizhMSFT shizhMSFT added the enhancement New feature or request label Mar 4, 2022
@mbaykara
Copy link
Author

mbaykara commented Mar 4, 2022

Look forward to this feature!

@shizhMSFT
Copy link
Contributor

/cc @FeynmanZhou @yizha1 for UX comments.

@mbaykara
Copy link
Author

AFAIK, when I try to push an artifact with multiple tags then I have to push one by one
i.e

oras push ${OCI_REGISTRY}/${OCI_REPOSITORY}:${TAG1}
oras push ${OCI_REGISTRY}/${OCI_REPOSITORY}:${TAG2}
oras push ${OCI_REGISTRY}/${OCI_REPOSITORY}:${TAG3}

which requires multiple API calls. But instead if can push as follow:

oras push ${OCI_REGISTRY}/${OCI_REPOSITORY} --tags=`${TAG1},${TAG2},${TAG3}

or something similar. /cc @FeynmanZhou

@FeynmanZhou
Copy link
Member

@mbaykara Thanks for your clarification! It makes sense, I think this scenario could be supported in ORAS 0.15.

@shizhMSFT
Copy link
Contributor

@jwang1013 Could you help this issue?

@wju-MSFT
Copy link
Contributor

I will take on this item.

@SteveLasker
Copy link
Contributor

SteveLasker commented Sep 2, 2022

I thought we already supported passing -t multiple times, but I was confusing it with az acr build.
What about supporting additional -t

oras push ${OCI_REGISTRY}/${OCI_REPOSITORY}:v1 \  
  -t ${OCI_REGISTRY}/${OCI_REPOSITORY}:v1.1 \  
  -t latest

I've allowed for including/excluding the full path to enable simplicty of just adding additional tags, similar to @mbaykara suggestion, but without breaking up the original reference.

@shizhMSFT shizhMSFT reopened this Sep 19, 2022
@shizhMSFT
Copy link
Contributor

I thought we already supported passing -t multiple times, but I was confusing it with az acr build. What about supporting additional -t

oras push ${OCI_REGISTRY}/${OCI_REPOSITORY}:v1 \  
  -t ${OCI_REGISTRY}/${OCI_REPOSITORY}:v1.1 \  
  -t latest

I've allowed for including/excluding the full path to enable simplicty of just adding additional tags, similar to @mbaykara suggestion, but without breaking up the original reference.

Using -t seems inconsistent in UX. If we want to make it consistent, it will be

oras push -t ${OCI_REGISTRY}/${OCI_REPOSITORY}:v1 \  
  -t ${OCI_REGISTRY}/${OCI_REPOSITORY}:v1.1 \  
  -t latest

However, it is still weird. Therefore, I think the original proposal makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
6 participants