-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable tagging manifests #519
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
/* | ||
Copyright The ORAS Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package tag | ||
|
||
import ( | ||
"github.com/spf13/cobra" | ||
"oras.land/oras-go/v2" | ||
"oras.land/oras/cmd/oras/internal/errors" | ||
"oras.land/oras/cmd/oras/internal/option" | ||
) | ||
|
||
type tagOptions struct { | ||
option.Common | ||
option.Remote | ||
|
||
srcRef string | ||
targetRef string | ||
} | ||
|
||
func TagCmd() *cobra.Command { | ||
var opts tagOptions | ||
cmd := &cobra.Command{ | ||
Use: "tag name<:tag|@digest> new_tag", | ||
Short: "[Preview] tag a manifest in the remote registry", | ||
Long: `[Preview] tag a manifest in the remote registry | ||
** This command is in preview and under development. ** | ||
Example - Tag the manifest 'v1.0.1' in 'locahost:5000/hello' to 'v1.0.2': | ||
oras tag localhost:5000/hello:v1.0.1 v1.0.2 | ||
Example - Tag the manifest with digest sha256:9463e0d192846bc994279417b50114606712d516aab45f4d8b31cbc6e46aad71 to 'v1.0.3' | ||
oras tag localhost:5000/hello@sha256:9463e0d192846bc994279417b50114606712d516aab45f4d8b31cbc6e46aad71 v1.0.3 | ||
`, | ||
Args: cobra.ExactArgs(2), | ||
PreRunE: func(cmd *cobra.Command, args []string) error { | ||
return opts.ReadPassword() | ||
}, | ||
RunE: func(_ *cobra.Command, args []string) error { | ||
opts.srcRef = args[0] | ||
opts.targetRef = args[1] | ||
return tagManifest(opts) | ||
}, | ||
} | ||
option.ApplyFlags(&opts, cmd.Flags()) | ||
return cmd | ||
} | ||
|
||
func tagManifest(opts tagOptions) error { | ||
ctx, _ := opts.SetLoggerLevel() | ||
repo, err := opts.NewRepository(opts.srcRef, opts.Common) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if repo.Reference.Reference == "" { | ||
return errors.NewErrInvalidReference(repo.Reference) | ||
} | ||
|
||
return oras.Tag(ctx, repo, opts.srcRef, opts.targetRef) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to consider the output when tagging multiple tags. /cc @FeynmanZhou @yizha1
This change will be in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to provide output msg for different kinds of tagging results. @wju-MSFT Let's discuss and confirm it.