feat: enable tagging manifests #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 9 9
Lines 399 399
=======================================
Hits 293 293
Misses 85 85
Partials 21 21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wwwsylvia
reviewed
Aug 23, 2022
qweeah
reviewed
Aug 23, 2022
qweeah
reviewed
Aug 23, 2022
qweeah
reviewed
Aug 23, 2022
Signed-off-by: Jun <[email protected]>
Signed-off-by: Jun <[email protected]>
qweeah
requested changes
Aug 25, 2022
|
@jwang1013 Need to resolve the DCO |
Signed-off-by: Jun <[email protected]>
Signed-off-by: Jun <[email protected]>
shizhMSFT
requested changes
Sep 1, 2022
shizhMSFT
reviewed
Sep 1, 2022
shizhMSFT
reviewed
Sep 1, 2022
| return errors.NewErrInvalidReference(repo.Reference) | ||
| } | ||
|
|
||
| return oras.Tag(ctx, repo, opts.srcRef, opts.targetRef) |
There was a problem hiding this comment.
We probably need to consider the output when tagging multiple tags. /cc @FeynmanZhou @yizha1
This change will be in another PR.
There was a problem hiding this comment.
Yes, we need to provide output msg for different kinds of tagging results. @wju-MSFT Let's discuss and confirm it.
Signed-off-by: Jun <[email protected]>
added 2 commits
September 5, 2022 13:48
Signed-off-by: Jun <[email protected]>
Signed-off-by: Jun <[email protected]>
|
@shizhMSFT PR is rebased and ready to be merged. |
TerryHowe
pushed a commit
to TerryHowe/oras
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Jun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #471
Signed-off-by: Jun [email protected]