Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: oras.Copy() may skip tagging if manifest blob already exists in the destination #243

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

m5i-work
Copy link
Contributor

Resolves #239

Signed-off-by: Wei Meng [email protected]

Signed-off-by: Wei Meng <[email protected]>
@m5i-work
Copy link
Contributor Author

@Wwwsylvia @qweeah Please take a look when you have time.

copy.go Outdated Show resolved Hide resolved
copy.go Outdated Show resolved Hide resolved
copy_test.go Show resolved Hide resolved
m5i-work added 2 commits July 20, 2022 11:20
Signed-off-by: Wei Meng <[email protected]>
Signed-off-by: Wei Meng <[email protected]>
copy.go Outdated Show resolved Hide resolved
copy.go Outdated Show resolved Hide resolved
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

copy.go Outdated Show resolved Hide resolved
Signed-off-by: Wei Meng <[email protected]>
@Wwwsylvia Wwwsylvia merged commit b898737 into oras-project:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: oras.Copy() may skip tagging if manifest blob already exists in the destination
3 participants