Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: oras.Copy() may skip tagging if manifest blob already exists in the destination #239

Closed
qweeah opened this issue Jul 15, 2022 · 4 comments · Fixed by #243
Closed

Bug: oras.Copy() may skip tagging if manifest blob already exists in the destination #239

qweeah opened this issue Jul 15, 2022 · 4 comments · Fixed by #243
Assignees
Labels
bug Something isn't working
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Jul 15, 2022

Reproduce Step

oras CLI version: 0.13.0

  1. Package an OCI artifact and push
    echo "test" > hi.txt && oras push $REG/$REPO hi.txt
  2. Repush the artifact
    oras push $REG/$REPO:tag hi.txt
  3. Push will be successful on client side but tag won't be created in the registry.

Root Cause

If a manifest blob is found existed (https://github.com/oras-project/oras-go/blob/main/copy.go#L154-L163), the copy process will be skipped as well as the retagging process.

Originally posted by @qweeah in oras-project/oras#447 (comment)

@qweeah qweeah changed the title Bug: when usingoras.Copy() tagging will be skipped if manifest blob already exists in the destination Bug: oras.Copy() may skip tagging if manifest blob already exists in the destination Jul 15, 2022
@Wwwsylvia Wwwsylvia added the bug Something isn't working label Jul 15, 2022
@Wwwsylvia Wwwsylvia added this to the v2.0.0-rc.2 milestone Jul 15, 2022
@Wwwsylvia
Copy link
Member

I will look into this next week.

@m5i-work
Copy link
Contributor

Please load balance to me.

@Wwwsylvia
Copy link
Member

Thanks @m5i-work. Assigned.

@Wwwsylvia
Copy link
Member

Hi @jpower432, FYI, this bug has been fixed in the latest main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants