Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gu in JDK11 distribution is invalid #1392

Closed
bobmcwhirter opened this issue Jun 17, 2019 · 4 comments
Closed

gu in JDK11 distribution is invalid #1392

bobmcwhirter opened this issue Jun 17, 2019 · 4 comments
Assignees
@sdedic

Comments

@bobmcwhirter
Copy link

When building the JDK11-centric distribution, the bin/gu still presumes it's under a non-existent JRE.

As it's an extracted dependency (I guess?) I'm finding no simple way to rewrite or provide an alternative gu_jdk11 source for the script.
@sdedic
Copy link
Member

sdedic commented Jun 18, 2019

@bobmcwhirter are you using master sources ? The launcher script seems correct (assuming lib/installer). Other hardcoded paths seem to be fixed by commit 627e13e

could you please elaborate ?

@bobmcwhirter
Copy link
Author

So yes, I guess the launcher script seems correct, but it's not finding it's own jar:

$ ./latest_graalvm_home/bin/gu
Error: Could not find or load main class org.graalvm.component.installer.ComponentInstaller
Caused by: java.lang.ClassNotFoundException: org.graalvm.component.installer.ComponentInstaller
$ ls -l latest_graalvm_home/lib/installer/
total 0
drwxr-xr-x  3 bob  staff  96 Jun 18 09:59 bin
drwxr-xr-x  3 bob  staff  96 Jun 18 09:52 components
$

The script seems to assume lib/installer/*.jar might exist?

@bobmcwhirter
Copy link
Author

Working on a fix. javaCompliance being applied more liberally.

bobmcwhirter pushed a commit to bobmcwhirter/graal that referenced this issue Jun 18, 2019
Ensure locator/installer build for JDK11 (fixes oracle#1392)
7ba2eb4 
Adjust the javaCompliance to allow for java 1.8+ instead of
exactly 1.8.
@bobmcwhirter bobmcwhirter mentioned this issue Jun 18, 2019
Closed
6 tasks
bobmcwhirter pushed a commit to bobmcwhirter/graal that referenced this issue Jul 8, 2019
Ensure locator/installer build for JDK11 (fixes oracle#1392)
ffa7247 
Adjust the javaCompliance to allow for java 1.8+ instead of
exactly 1.8.
@sdedic
Copy link
Member

sdedic commented Nov 13, 2019

Already fixed by 6c1fe58

@sdedic sdedic closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdedic sdedic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobmcwhirter @sdedic