Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Java 11 #818

Closed
6 tasks
dmlloyd opened this issue Feb 8, 2019 · 6 comments
Closed
6 tasks

Switch to Java 11 #818

dmlloyd opened this issue Feb 8, 2019 · 6 comments
Labels
triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Feb 8, 2019

This is the blanket issue to cover switching to Java 11. Here's the check list:

  • Introduce an artifact which contains the contents of the com.oracle.svm.driver package from the SubstrateVM build (the default coordinates are com.oracle.substratevm:svm-driver; use mx maven-install to install it locally after checking out & building with the vm-1.0.0-rc11 tag under Java 11)
  • Make the native image generator depend on this artifact
  • Change org.jboss.shamrock.creator.phase.nativeimage.NativeImagePhase to use com.oracle.svm.driver.NativeImage from the driver artifact directly for normal builds, and via container execution of java (11) for container builds
  • Delete checks for GRAALVM_HOME
  • Update POMs to require Java 11 (use <release>11</release> in the compiler plugin, not -source/-target)
  • Full integration test run on Linux & Windows

Note that some of these steps will have to change if the class loading changes come in first.

@dmlloyd
Copy link
Member Author

dmlloyd commented Feb 8, 2019

The alternative would be to require some external native-image package to be installed.

@Sanne
Copy link
Member

Sanne commented Feb 12, 2019

Also before we move on to require Java 11 as base, we should start having CI monitor that what we have today is actually compatible with Java 11 - at least in JVM mode.

@bobmcwhirter
Copy link
Contributor

oracle/graal#1392

@gsmet
Copy link
Member

gsmet commented Nov 25, 2019

@dmlloyd should I close this one? Looks like the effort is now made in separate issues specific to GraalVM?

@dmlloyd
Copy link
Member Author

dmlloyd commented Nov 25, 2019

Yep this is out of date.

@dmlloyd dmlloyd closed this as completed Nov 25, 2019
@dmlloyd
Copy link
Member Author

dmlloyd commented Nov 25, 2019

Please see #5691 for the up-to-date migration steps.

@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

4 participants