Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: #5186: MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5191

Merged
merged 9 commits into from
Dec 5, 2023
Merged

Fix: #5186: MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5191

merged 9 commits into from
Dec 5, 2023

Conversation

theMr17
Copy link
Collaborator

@theMr17 theMr17 commented Oct 16, 2023 •
edited
Loading

Explanation

Fixes #5186 [part of #5169]

  1. MissingDefaultResource has been fixed already by Localisation updates from https://translatewiki.net. #5172. It had issues with these plurals:

  2. For AppCompatCustomView, it is fixed by replacing the Normal views with AppCompat views

  3. <fragment/> tags are replaced with <androidx.fragment.app.FragmentContainerView/>, with some changes in the NavigationDrawerFragment to ensure that binding has been initialized before it is accessed.

Screen Recording

Screenrecording_20231115_142453.mp4

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@theMr17 theMr17 requested a review from a team as a code owner October 16, 2023 11:36
@theMr17 theMr17 requested a review from adhiamboperes October 16, 2023 11:36
@adhiamboperes adhiamboperes self-assigned this Oct 16, 2023
@adhiamboperes adhiamboperes reopened this Oct 16, 2023
@github-actions
Copy link

Hi! @theMr17 Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

adhiamboperes
adhiamboperes requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17!

Please add a video demonstrating that the navigation drawer behaves as expected with the initialization changes, for all the menu options.

app/src/main/java/org/oppia/android/app/drawer/NavigationDrawerFragment.kt Outdated Show resolved Hide resolved
@adhiamboperes adhiamboperes added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 18, 2023
@oppiabot
Copy link

oppiabot bot commented Oct 25, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 25, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Oct 26, 2023
@adhiamboperes adhiamboperes removed the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 31, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 7, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 7, 2023
@adhiamboperes adhiamboperes removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 10, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 22, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 22, 2023
@theMr17 theMr17 removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 23, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Nov 30, 2023

Hi @theMr17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Nov 30, 2023
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Dec 2, 2023
@theMr17
Merge remote-tracking branch 'origin/add-fragment-deps' into fix/miss…
1cdeab7 
…ingDefaultResource-appCompatCustomView-fragmentTagUsage
@theMr17 theMr17 requested review from a team as code owners December 5, 2023 05:15
@theMr17
Copy link
Collaborator Author

theMr17 commented Dec 5, 2023

@adhiamboperes PTAL

@oppiabot oppiabot bot assigned adhiamboperes and unassigned theMr17 Dec 5, 2023
@oppiabot OppiaBot
Copy link

oppiabot bot commented Dec 5, 2023

Unassigning @theMr17 since a re-review was requested. @theMr17, please make sure you have addressed all review comments. Thanks!

adhiamboperes
adhiamboperes approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theMr17, this LGTM!

@adhiamboperes adhiamboperes merged commit 5075c54 into oppia:develop Dec 5, 2023
42 checks passed
@theMr17 theMr17 mentioned this pull request Dec 19, 2023
Closed
This was referenced Dec 23, 2023
Closed
Merged
BenHenning added a commit that referenced this pull request Dec 23, 2023
@BenHenning
Fix part of #5284: Revert "Fix #5266: Call setUpDrawer( ) directly if…
31dfd2a 
… binding already initialized" (#5285)

Fixes part of #5284

Reverts #5276 as part of preparing to revert #5191.

Note that this reintroduces #5266 but that should stay fixed once #5191
is reverted.
adhiamboperes added a commit that referenced this pull request Dec 23, 2023
@adhiamboperes
Revert "Fix: #5186: MissingDefaultResource + AppCompatCustomView + Fr…
17ebf2b 
…agmentTagUsage (#5191)"

This reverts commit 5075c54.
@adhiamboperes adhiamboperes mentioned this pull request Dec 23, 2023
Merged
BenHenning pushed a commit that referenced this pull request Dec 23, 2023
@adhiamboperes
Fix #5284: Revert "Fix: #5186: MissingDefaultResource + AppCompatCust…
658c596 
…omView + FragmentTagUsage" (#5287)

Fix #5284: Reverts #5191. See issue for details.

This should be a clean revert.
BenHenning added a commit that referenced this pull request Dec 23, 2023
@BenHenning
Fix part of #5284: Revert "Fix #5266: Call setUpDrawer( ) directly if…
1f465cf 
… binding already initialized" (#5285)

Fixes part of #5284

Reverts #5276 as part of preparing to revert #5191.

Note that this reintroduces #5266 but that should stay fixed once #5191
is reverted.
BenHenning pushed a commit that referenced this pull request Dec 23, 2023
@adhiamboperes @BenHenning
Fix #5284: Revert "Fix: #5186: MissingDefaultResource + AppCompatCust…
cf3fc36 
…omView + FragmentTagUsage" (#5287)

Fix #5284: Reverts #5191. See issue for details.

This should be a clean revert.
@BenHenning BenHenning mentioned this pull request Dec 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes adhiamboperes approved these changes

Assignees

@adhiamboperes adhiamboperes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MissingDefaultResource + AppCompatCustomView + FragmentTagUsage
2 participants
@theMr17 @adhiamboperes