[BUG]: App crashes in production builds #5284
Assignees
Labels
bug
End user-perceivable behaviors which are not desirable.
Impact: High
High perceived user impact (breaks a critical feature or blocks a release).
Work: Low
Solution is clear and broken into good-first-issue-sized chunks.
Milestone
Comments
BenHenning
added
bug
BenHenning
added
the
Impact: High
|
NB: This is blocking us from launching beta 0.12 of the app. I'm aiming to revert the PR that caused it, plus #5276 since it follows that PR. |
|
Forgot to attach the stack trace in the original posting: |
adhiamboperes
added
Work: Low
github-project-automation
bot
moved this to Todo
in [Team] Developer Workflow & Infrastructure - Android
github-project-automation
bot
moved this to Todo
in [Team] Core Learner and Mastery flows & UI Frontend - Android
BenHenning
pushed a commit
that referenced
this issue
Dec 23, 2023
github-project-automation
bot
moved this from Todo
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
BenHenning
pushed a commit
that referenced
this issue
Dec 23, 2023
6 tasks
BenHenning
added a commit
that referenced
this issue
Dec 23, 2023
## Explanation This fixes #5284 for the upcoming 0.12 release by cherry-picking #5285 and #5287 into the release branch. Both cherry-picks happened cleanly, so the review is expected to be straightforward. ## Essential Checklist - [ ] ~The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)~ - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only See corresponding cherry-picks and original PRs for references on what reverted behavior is being checked in within this PR. --------- Co-authored-by: Adhiambo Peres <[email protected]>
6 tasks
adhiamboperes
pushed a commit
that referenced
this issue
Dec 5, 2024
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fixes [#5168](#5186) 1. For `AppCompatCustomView`, replaced it with AppCompat Views 2. For `FragmentTagUsage`, replaced `<fragment/>` with <androidx.fragment.app.FragmentContainerView/>. Made some changes to `NavigationDrawerFragment` to: - ensured `setUpDrawer()` is called first to initialize the `drawerLayout`, `toolbar` and `menuItemId` - followed by `onCreateView()` ensuring to bind the fragment - followed on `onViewCreated()` to setup drawer functions/listeners 3. Faced an issue similar to [drawer not working](#5266), by minimising and resuming the app, (the drawer button stopped working). - Fixed this by removing `onRestart()` from respective Activies making a call to `setUpNavigationDrawer()` which at that point is not necessary, since the fragment has been inflated initially, and would be re-inflated if the fragment is recreated. 4. Also tested this [bug](#5284) following the steps to reproduce. No issues encountered **Lint report (Before):**  **Lint report (After):**  ## Screen Record https://github.com/user-attachments/assets/6db98657-d470-4263-a5ac-d055f4d64e66 ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When trying to navigate to the home screen (or likely any activity with a navigation drawer) the app will crash on production builds (alpha, beta, GA).
Steps To Reproduce
bazel run //:install_oppia_beta.Expected Behavior
The app should not crash.
Screenshots/Videos
No response
What device/emulator are you using?
Pixel XL
Which Android version is your device/emulator running?
SDK 33
Which version of the Oppia Android app are you using?
0.11-beta-74f4bafc71
Additional Context
From investigation, it seems that this was caused by #5191.
The text was updated successfully, but these errors were encountered: